Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Case Selection for Case Management Page #35288

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zandre-eng
Copy link
Contributor

Product Description

Only selected cases and mobile workers will now be considered for disbursement. If no cases are selected, then all cases will be considered. The same is true for mobile workers:
disburse-selection

If a polygon is added to the map before loading in the mobile workers, these mobile workers will now automatically be selected:
select-users-when-adding

Technical Summary

Link to ticket here.

This PR addresses two bugs for the Case Management page. Specifically:

  • All cases and mobile workers are considered for disbursement, regardless of what has been selected.
  • Loading in mobile workers after applying polygon filtering does not automatically cause the mobile workers to be selected.

Feature Flag

GEOSPATIAL

Safety Assurance

Safety story

  • Local testing

Small front-end only change.

Automated test coverage

N/A

QA Plan

No QA planned.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@zandre-eng zandre-eng added the product/feature-flag Change will only affect users who have a specific feature flag enabled label Oct 29, 2024
@zandre-eng zandre-eng marked this pull request as ready for review October 29, 2024 10:09
@@ -534,6 +534,13 @@ hqDefine('geospatial/js/models', [
});
return layerRemoved;
};

self.hasSelectedUsers = function () {
return self.userMapItems().some((userMapItem) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@ajeety4 ajeety4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and clear 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/feature-flag Change will only affect users who have a specific feature flag enabled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants